[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

Thu Jul 28 11:16:36 PDT 2022

akyrtzi added a comment.

In D130710#3685509 <https://reviews.llvm.org/D130710#3685509>, @v.g.vassilev wrote:

> In D130710#3685470 <https://reviews.llvm.org/D130710#3685470>, @akyrtzi wrote:
>
>> @v.g.vassilev is the functionality of "write `ORIGINAL_PCH_DIR` and resolve headers relative to it if PCH file and headers moved together" used by `Cling`?
>
> We currently use `-fmodules-embed-all-files` which zips all header files in a blob in the PCH/PCM that gives us flexibility to not require the headers to be present at a specific location. We have mostly moved to PCMs and the PCH is of less interest to us. Does that patch help making the implicitly built module files easier to relocate?

Not sure whether `ORIGINAL_PCH_DIR` relates to implicitly built module files or not, I'm wondering whether `ORIGINAL_PCH_DIR` is still useful and, if I understand correctly, it's not useful for `Cling` since it embeds the header file contents, right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130710/new/

https://reviews.llvm.org/D130710