[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/test/CodeGen/attr-maybeundef-template.cpp:3
+
+// CHECK-LABEL: @_Z5test4IfEvT_(
+// CHECK-NEXT:  entry:
----------------
This mangling works for Itanium targets, but doesn't match MSVC targets, which is why the test is failing on Windows.


================
Comment at: clang/test/CodeGen/attr-maybeundef.c:48
+
+// CHECK: declare void @VariadicFunction(i32 noundef, ...)
+
----------------
It looks like dso_local is missing here on Windows and expected to be missing on Linux? Not certain what's up with that...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130224/new/

https://reviews.llvm.org/D130224