[PATCH] D130510: Missing tautological compare warnings due to unary operators

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 27 12:11:21 PDT 2022


aaron.ballman added a comment.

In D130510#3683078 <https://reviews.llvm.org/D130510#3683078>, @Codesbyusman wrote:

> In D130510#3682902 <https://reviews.llvm.org/D130510#3682902>, @aaron.ballman wrote:
>
>> Thank you for this, I think this is good incremental progress and is almost ready to go. Just a few small nits, but also, can you also add a release note for the fix (be sure to mention which issue is being closed too).
>>
>> Note, the precommit CI failures are unrelated to the changes in this patch.
>
> where should I write this release note. Like in comment or somewhere else?

All of Clang's release notes live in: https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst and you'd want to put your note under `Improvements to Clang's diagnostics` (since you're making the diagnostic behavior better) or `Bug Fixes` (since there's a GitHub issue associated with it). I'd probably list it under Bug Fixes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130510/new/

https://reviews.llvm.org/D130510



More information about the cfe-commits mailing list