[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 27 07:37:28 PDT 2022


adamcz created this revision.
adamcz added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
adamcz requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

This is very useful information for better understanding performance and
preamble builds don't happen that often, so it's not that spammy.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130636

Files:
  clang-tools-extra/clangd/Preamble.cpp


Index: clang-tools-extra/clangd/Preamble.cpp
===================================================================
--- clang-tools-extra/clangd/Preamble.cpp
+++ clang-tools-extra/clangd/Preamble.cpp
@@ -552,7 +552,7 @@
   }
 
   if (BuiltPreamble) {
-    vlog("Built preamble of size {0} for file {1} version {2} in {3} seconds",
+    log("Built preamble of size {0} for file {1} version {2} in {3} seconds",
          BuiltPreamble->getSize(), FileName, Inputs.Version,
          PreambleTimer.getTime());
     std::vector<Diag> Diags = PreambleDiagnostics.take();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130636.448035.patch
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220727/2cf792e5/attachment.bin>


More information about the cfe-commits mailing list