[PATCH] D130600: [clang][dataflow] Handle return statements

Sam Estep via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 27 06:08:16 PDT 2022


samestep added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:338-339
+    if (Loc == nullptr) {
+      // The outermost context does not set a storage location for `return`, so
+      // in that case we just ignore `return` statements.
+      return;
----------------
sgatev wrote:
> Let's make this a FIXME to set a storage location for the outermost context too.
@sgatev I could add a `FIXME` for that, or I could just do it in this same patch; do you have a preference between those two options?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130600/new/

https://reviews.llvm.org/D130600



More information about the cfe-commits mailing list