[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 26 20:51:56 PDT 2022


ChuanqiXu added a comment.

In D130585#3680189 <https://reviews.llvm.org/D130585#3680189>, @ilya-biryukov wrote:

> I wonder whether the right fix for this should generalize to `Mergeable<T>`.
> The fact that `Mergeable::getFirstDecl` checks if the decl is coming from the AST file before looking up its primary merged decl is probably a performance optimization, not a deliberate semantic.

Agreed. I think we could omit the `isFromASTFile` part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130585/new/

https://reviews.llvm.org/D130585



More information about the cfe-commits mailing list