[PATCH] D130593: [clang][dataflow] Separate context by frame

[Sam Estep via Phabricator via cfe-commits]

samestep added a comment.

In D130593#3681126 <https://reviews.llvm.org/D130593#3681126>, @xazax.hun wrote:

> While separate call strings are properly isolated from each other, repeated analysis of the same call is not:|
>
>   while (...)
>   {
>     foo(...);
>   }
>
> In the above code snippet, we will end up analyzing foo with leftover state from the previous iteration. The analysis can potentially observe state private to the previous call in the current call. Do I miss something or is this intentional?

Correct, you didn't miss something. I'm not really sure of the best way to deal with this; in the short term, my plan is to only allow analysis of a callee when it is not already present in the call-string. @ymandel any ideas for the longer term?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130593/new/

https://reviews.llvm.org/D130593