[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 26 16:50:35 PDT 2022


hubert.reinterpretcast added a comment.

Tests require fixing.



================
Comment at: llvm/test/LTO/PowerPC/data-sections-aix.ll:18-19
+
+; CHECK-NOT:              (csect: .data)
+; CHECK:                  00000000 g O .data {{.*}} var
+
----------------
Unfortunately (without the change) this would pass even if the line was
```
00000000 g     O .data (csect: .data)   00000000 var
```



================
Comment at: llvm/test/LTO/PowerPC/data-sections-linux.ll:20
+
+; CHECK-NO-DATA-SECTIONS-NOT: .var
+; CHECK-NO-DATA-SECTIONS:     0000000000000000 g O .bss {{.*}} var
----------------
This is not needed. The whitespace before the `{{.*}}` will not match if `.bss.var` is encountered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129401/new/

https://reviews.llvm.org/D129401



More information about the cfe-commits mailing list