[PATCH] D130018: [HLSL] Add HLSLResource attribute

Tue Jul 26 09:46:12 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a documentation question.

================
Comment at: clang/include/clang/Basic/AttrDocs.td:6473-6475
+The HLSL ``resource`` attribute is not valid to manually specify in
+HLSL. It is applied by the compiler to HLSL resource type objects enabling them
+to be handled appropriately in CodeGen.
----------------
Because the attribute cannot be written by the user, it seems like we shouldn't bother documenting this attribute at all. WDYT? If you agree, you can mark the attribute as `Undocumented` in Attr.td.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130018/new/

https://reviews.llvm.org/D130018