[PATCH] D130553: [clang][lld][cmake] Simplify header dirs
John Ericson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 26 07:59:33 PDT 2022
Ericson2314 added inline comments.
================
Comment at: clang/CMakeLists.txt:81
# path is removed.
- set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}")
+ set(INCLUDE_DIRS ${LLVM_INCLUDE_DIRS})
set(LLVM_OBJ_DIR "${LLVM_BINARY_DIR}")
----------------
sebastian-ne wrote:
> Do we need to add `"${LLVM_BINARY_DIR}/include"` here as well?
Pretty sure we shouldn't be cause that should be one of the elements of the list when LLVM is also being built in this CMake invocation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130553/new/
https://reviews.llvm.org/D130553
More information about the cfe-commits
mailing list