[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

Mon Jul 25 16:27:02 PDT 2022

jpenix-quic added a comment.

Thank you for taking a look at this and thank you for the feedback!

I'm not sure if I am entirely following/I think I am confusing myself on some of the specifics. My understanding of your suggestion is that, rather than add and create a call to a fconvert-specific runtime function (`ConvertOption`) I should look towards implementing and calling a runtime function/API that (conceptually) looks something like `SetRuntimeDefaults(FORT_CONVERT="SWAP", [...])` to set whatever was specified on the command line.

I think where I'm getting confused is when you mention default environment variable settings or translating the command-line options into the equivalent environment settings and passing them as defaults: is the idea to set the actual (in this case) `FORT_CONVERT` environment variable if it hasn't already been defined in the environment, with the goal of letting the existing `FORT_CONVERT` handling deal with everything? Or, is directly setting the `executionEnvironment.conversion` value like I tried to do in `ConvertOption` ok, but I need to rethink the `ConvertOption` API itself? If the goal is to set `FORT_CONVERT`, I'm getting a bit hung up on `FORT_CONVERT` currently being handled as part of the "hardcoded" main in Fort_main.c.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130513/new/

https://reviews.llvm.org/D130513