[PATCH] D130446: [apinotes] Upstream changes to `APINotesYAMLCompiler.cpp`.
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 25 08:19:09 PDT 2022
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
Can you please add a round trip test as well? Additionally, please add a proper commit message to describe the change here.
================
Comment at: clang/lib/APINotes/APINotesYAMLCompiler.cpp:425
+ Optional<StringRef> ReleaseOp;
+ FunctionsSeq MemberFuncs;
};
----------------
Any reason to shorten `Functions` to `Funcs`? It seems that it would be a bit odd given the other members.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130446/new/
https://reviews.llvm.org/D130446
More information about the cfe-commits
mailing list