[PATCH] D130414: [pseudo] Reorganize CXX.h enums

[Utkarsh Saxena via Phabricator via cfe-commits]

usaxena95 added inline comments.


================
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54-62
+namespace dummy {
+enum Rule {
+//clang-format off
+#define NONTERMINAL(NAME, ID) };} namespace NAME { enum Rule : RuleID {
+#define RULE(LHS, RHS, ID) RHS = ID,
 #include "CXXSymbols.inc"
+  //clang-format on
----------------
sammccall wrote:
> hokein wrote:
> > why there is a dummy namespace here?
> for each NT, we close the previous ns+enum and open new ones.
> For this to work for the first NT, we have to open an ns+enum.
> 
> I can add a comment, but would prefer to do this some other way?
I would include this block in the clang-format off block to show these are for the generated code.
```
//clang-format off
namespace dummy { enum Rule {
...
};}
//clang-format on
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130414/new/

https://reviews.llvm.org/D130414