[clang] 214a760 - Switch from XFAIL to UNSUPPORTED; NFC

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 25 04:21:27 PDT 2022


Author: Aaron Ballman
Date: 2022-07-25T07:21:19-04:00
New Revision: 214a760a211606d14b3b2b852bd9d9a21149317e

URL: https://github.com/llvm/llvm-project/commit/214a760a211606d14b3b2b852bd9d9a21149317e
DIFF: https://github.com/llvm/llvm-project/commit/214a760a211606d14b3b2b852bd9d9a21149317e.diff

LOG: Switch from XFAIL to UNSUPPORTED; NFC

This test is currently marked as XFAIL for Windows, but running the
test with a debug build of clang-repl.exe crashes with a modal system
dialog. This switches the test to UNSUPPORTED instead. This makes the
test behavior less onerous for those of us doing Debug builds, at the
expense of a minor bit of coverage if the test were ever to start
passing unexpectedly on Windows (which seems like an unlikely event).

Added: 
    

Modified: 
    clang/test/Interpreter/execute-weak.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/Interpreter/execute-weak.cpp b/clang/test/Interpreter/execute-weak.cpp
index e4577e3ced6e9..7d0b7061e5019 100644
--- a/clang/test/Interpreter/execute-weak.cpp
+++ b/clang/test/Interpreter/execute-weak.cpp
@@ -2,9 +2,8 @@
 // RUN: clang-repl "int i = 10;" 'extern "C" int printf(const char*,...);' \
 // RUN:            'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s
 // REQUIRES: host-supports-jit
-// UNSUPPORTED: system-aix
-// XFAIL: system-windows
 // CHECK-DRIVER: i = 10
+// UNSUPPORTED: system-aix, system-windows
 // RUN: cat %s | clang-repl | FileCheck %s
 extern "C" int printf(const char *, ...);
 int __attribute__((weak)) bar() { return 42; }


        


More information about the cfe-commits mailing list