[PATCH] D128667: [WIP] Add Zstd ELF support

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 24 23:13:27 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:1015
+  } else {
+    if (Config.DecompressDebugSections && !compression::zstd::isAvailable())
+      return createStringError(
----------------
For --decompress-debug-sections, the zstd error should be reported only when a compressed debug section using zstd is found. zlib is similar.

I cleaned up legacy zdebug code from llvm-objcopy, fixed an uninitialized ch_reserved bug. Created D130458 as an alternative patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128667/new/

https://reviews.llvm.org/D128667



More information about the cfe-commits mailing list