[PATCH] D130421: [Clang] De-deprecate volatile compound operations
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 24 06:44:09 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: clang/docs/ReleaseNotes.rst:519-523
- Implemented `P2290 Delimited escape sequences <https://wg21.link/P2290R3>`_.
This feature is available as an extension in all C and C++ language modes.
- Implemented `P2071 Named universal character escapes <https://wg21.link/P2290R2>`_.
This feature is available as an extension in all C and C++ language modes.
+- Implemented `P2327 De-deprecating volatile compound operations <https://wg21.link/P2327R1>`_
----------------
NFC nit: we should add the revision number to the link titles as well, as done above. (Feel free to land as an NFC change if you want).
================
Comment at: clang/lib/Sema/SemaExpr.cpp:13943-13944
// [Compound-assignment] expressions are deprecated if E1 has
// volatile-qualified type
- Diag(Loc, diag::warn_deprecated_compound_assign_volatile) << LHSType;
+ // and op is not one of the bitwise operators |, &, ˆ
+ switch (Opc) {
----------------
re-flowing the comment somewhat.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130421/new/
https://reviews.llvm.org/D130421
More information about the cfe-commits
mailing list