[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 22 15:46:43 PDT 2022


shafik updated this revision to Diff 446997.
shafik marked 4 inline comments as done.
shafik added a comment.

- Addressed style comments
- Changed to use initializer_list version of std::max
- Added test to cover enum with -1 as sole enumerator value


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130301/new/

https://reviews.llvm.org/D130301

Files:
  clang/lib/Sema/SemaDecl.cpp
  clang/test/CodeGenCXX/pr12251.cpp
  compiler-rt/test/ubsan/TestCases/Misc/enum.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130301.446997.patch
Type: text/x-patch
Size: 4170 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220722/6eae3ca2/attachment.bin>


More information about the cfe-commits mailing list