[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In D126731#3672666 <https://reviews.llvm.org/D126731#3672666>, @vsapsai wrote:

> In D126731#3670896 <https://reviews.llvm.org/D126731#3670896>, @sammccall wrote:
>
>> Hmm, I also don't know.
>> The idea here is that we specifically depend only on the TokenKind enum from TokenKinds.h (which doesn't need any generated headers), not on other headers from clang/include/Basic (which might), and not on building/linking clangBasic itself.
>> In a modules world, maybe that means we need TokenKinds.h to be its own module, or a non-modular header, or something?
>
> I went with the approach of putting TokenKinds.h (and TokenKinds.def) into its own module D130377 <https://reviews.llvm.org/D130377>.
>
> In D126731#3670896 <https://reviews.llvm.org/D126731#3670896>, @sammccall wrote:
>
>> I'm also not sure on the support status of the modules build: I can't find a buildbot covering it or docs. Is this something I need to fix, or is it an experimental build like GN/Bazel?
>
> I know at least about https://green.lab.llvm.org/green/job/lldb-cmake/ building with modules. I agree it's not a common configuration on buildbots but it's not experimental like GN/Bazel. As for the fixing the issue, it is covered by https://llvm.org/docs/DeveloperPolicy.html#quality , i.e., it is the author's responsibility but the reporter is responsible for making sure the author is equipped to do so (or fix themselves if they cannot help the author).

Thank you! I had forgotten about the greendragon bots.
And thanks for the module fix, if it's not that simple I'm happy to re-add the dep while i try to work something out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126731/new/

https://reviews.llvm.org/D126731