[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

[Amy Kwan via Phabricator via cfe-commits]

amyk added a comment.

In D130066#3670875 <https://reviews.llvm.org/D130066#3670875>, @sammccall wrote:

> In D130066#3670745 <https://reviews.llvm.org/D130066#3670745>, @amyk wrote:
>
>> Hi!
>>
>> It appears that this patch is causing a build failure on a couple PPC bots that build with shared libraries:
>> https://lab.llvm.org/buildbot/#/builders/57/builds/20179
>> https://lab.llvm.org/buildbot/#/builders/121/builds/21678
>>
>> The specific error that occurs looks like this:
>>
>>   2.485 [936/22/19] Linking CXX shared library lib/libclangPseudoCXX.so.15git
>>   FAILED: lib/libclangPseudoCXX.so.15git 
>>   : && /home/buildbots/clang.11.0.0/bin/clang++ --gcc-toolchain=/opt/rh/devtoolset-7/root/usr -fPIC -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libclangPseudoCXX.so.15git -o lib/libclangPseudoCXX.so.15git tools/clang/tools/extra/pseudo/lib/cxx/CMakeFiles/obj.clangPseudoCXX.dir/CXX.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libclangPseudo.so.15git  lib/libclangPseudoGrammar.so.15git  lib/libLLVMSupport.so.15git  -Wl,-rpath-link,/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib && :
>>   tools/clang/tools/extra/pseudo/lib/cxx/CMakeFiles/obj.clangPseudoCXX.dir/CXX.cpp.o:(.toc+0x10): undefined reference to `clang::charinfo::InfoTable'
>>   clang++: error: linker command failed with exit code 1 (use -v to see invocation)
>>
>> Would you be able to take a look at this issue (or revert the patch if this requires more time to resolve)? Thank you in advance.
>
> Sorry about that. d26ee284ded30aff46 <https://reviews.llvm.org/rGd26ee284ded30aff46a00986b5c966238e2279be> links in clangBasic for this dep.
> (I think it wasn't showing up in the non-shared builds because these functions were always inlined)

Thank you for fixing the build failures, @sammccall, I appreciate it! The bots are back to green now. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130066/new/

https://reviews.llvm.org/D130066