[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 22 05:29:45 PDT 2022


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.

LGTM



================
Comment at: clang-tools-extra/clangd/AST.cpp:830
+    assert(Parameters.size() <=
+           static_cast<size_t>(std::distance(Args.begin(), Args.end())));
+    for (auto Begin = Args.begin(), End = Args.end() - Parameters.size() + 1;
----------------
NIT: could be shorter with `llvm::size(Args)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130260/new/

https://reviews.llvm.org/D130260



More information about the cfe-commits mailing list