[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

Thu Jul 21 20:09:27 PDT 2022

vsapsai added a comment.

In D128695#3670552 <https://reviews.llvm.org/D128695#3670552>, @ChuanqiXu wrote:

> It looks like we lack a patch to use it in parser, right?

Kinda. Things get a little bit more complicated before we can do that. But to see the bigger picture, I've published all planned intermediate steps with the final D130327 <https://reviews.llvm.org/D130327>. And there in clang/lib/Parse/ParseObjc.cpp you can see how `ODRDiagsEmitter` is used in the parser.

I'm not opening those patches for review yet as I want to polish them a little bit and to test all of this stuff on real projects. Landing all of NFC stuff should be sufficient to start testing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128695/new/

https://reviews.llvm.org/D128695