[PATCH] D130261: [clangd] Refactor forwarding call detection logic

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1446
+    void bax(Args... args) { foo({args...}, args...); }
+
+    void foo() {
----------------
ilya-biryukov wrote:
> NIT: maybe test for the case with a single expansion here:
> ```
> foo(Foo(args...), 1);
> foo({args...}, 1);
> ```
> ?
> 
> 
> testing multiple expansions is also interesting, but seems orthogonal to the change being made here.
> E.g. tests for it would probably benefit from more than 2 appearances of `args` and more complicated nesting structures.
> 
> 
this was mostly a "sugar" patch, the tests are part of D130260 but I didn't do a good job of splitting the change 😅 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130261/new/

https://reviews.llvm.org/D130261