[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 08:51:42 PDT 2022


awarzynski added a comment.

In D130078#3667188 <https://reviews.llvm.org/D130078#3667188>, @MaskRay wrote:

> `forwardOptions` will be better if you are renaming it anyway.

I'd rather create a separate patch and update all other methods to follow LLVM's style. Any idea why the style is not followed in Clang.h <https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.h>?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130078/new/

https://reviews.llvm.org/D130078



More information about the cfe-commits mailing list