[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

Thu Jul 21 05:59:50 PDT 2022

jhuber6 added a comment.

In D122683#3668423 <https://reviews.llvm.org/D122683#3668423>, @jhuber6 wrote:

> In D122683#3668412 <https://reviews.llvm.org/D122683#3668412>, @mgorny wrote:
>
>> I'm sorry for noticing it this late but this change seems to have broken the test on 32-bit x86:
>
> Seems to be a difference in the alignment, I'm not sure why this changes though because the test should specify x86_64.

Actually I think the alignment comes from `alignof` on a struct which doesn't care about the target, just the machine compiling it. Even still that struct has `int64_t` members so I figured it would be 8-byte aligned. I should probably just hard-code it to 8.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122683/new/

https://reviews.llvm.org/D122683