[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 05:58:15 PDT 2022


erichkeane added a comment.

In D126907#3667265 <https://reviews.llvm.org/D126907#3667265>, @ChuanqiXu wrote:

> In D126907#3665900 <https://reviews.llvm.org/D126907#3665900>, @erichkeane wrote:
>
>> The more I look at this... the more I question my approach.  I now am definitely sure we won't make Clang15, and hope that I can figure something better out for 16 :/
>
> I feel like it could be helpful to split it into several small patches next time.

I REALLY wish I knew how to make that happen.  The problem is the main idea (deferring instantiation) is an 'all or nothing' that really seems to break things.  There are a handful of small-ish 'cleanup' tasks that I did along the way, and could probably come up with another, but I'm not sure how much I can remove from the patch to split it up :/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907



More information about the cfe-commits mailing list