[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

Tobias Ribizel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 05:47:05 PDT 2022


upsj added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:721
+    }
+  )cpp" /*, ExpectedHint{"s: ", "param1"}, ExpectedHint{"x: ", "param2"}*/);
+}
----------------
I'm not sure whether we should detect this case, since it would be nice to handle, but also involves digging deep through `CXXConstructExpression -> MaterializeTemporaryExpression -> CXXMemberCallExpr -> MemberExpr -> DeclRefExpr`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130259/new/

https://reviews.llvm.org/D130259



More information about the cfe-commits mailing list