[PATCH] D130089: update-test-checks: safely handle tests with #if's

Matheus Izvekov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 04:29:44 PDT 2022


mizvekov added a comment.

In D130089#3668111 <https://reviews.llvm.org/D130089#3668111>, @nhaehnle wrote:

> My version of `diff` has a `--strip-trailing-cr` flag. But I don't really see that being used in many places at all.

What I see is that the sources are checked out with the expected windows (\r\n) line endings, but the file we generate (`build\llvm\tools\clang\test\utils\update_cc_test_checks\Output\ifdef.test.tmp.c`) has unix (\n) line endings.
I am not sure yet what we would usually do here, but it makes more sense to generate the file with line endings expected for the native platform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130089/new/

https://reviews.llvm.org/D130089



More information about the cfe-commits mailing list