[PATCH] D130089: update-test-checks: safely handle tests with #if's

Matheus Izvekov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 03:58:47 PDT 2022


mizvekov added a comment.

In D130089#3668061 <https://reviews.llvm.org/D130089#3668061>, @nhaehnle wrote:

> I've been staring at ifdef.test vs. basic-cplusplus.test for a while now and don't see any relevant difference, including when I look at the line endings in a hex editor (on Linux). So I guess there is a difference that appears only on Windows somehow? Unfortunately, I simply have no idea at the moment where it could come from.

Yeah it could be that there is some flag we should be passing to diff, or some other thing that we normally do on llvm to take care of this issue, so that diff ignores the line ending difference.
I haven't had time to look at what is the standard practice we have for that yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130089/new/

https://reviews.llvm.org/D130089



More information about the cfe-commits mailing list