[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

Wed Jul 20 23:45:16 PDT 2022

iains accepted this revision.
iains added a comment.
This revision is now accepted and ready to land.

In D130138#3667172 <https://reviews.llvm.org/D130138#3667172>, @MaskRay wrote:

> In D130138#3664913 <https://reviews.llvm.org/D130138#3664913>, @iains wrote:
>
>> makes sense to me...
>>
>> I guess the name looks long at first, but it's specific (I find that easy-to-remember flag names are more important than short-to-type ones, but maybe that's just me) - I wonder if @MaskRay has any comments on the flag name,
>>
>> For the record:
>> GCC uses : -flang-info-include-translate (-flang for flag-language, rather than 'flang', of course).
>> (which is a note, i.e. similar idea to the remark)
>>
>> BTW.. (not for this patch, of course)
>> GCC also has 
>> info-include-translate-not
>> Note #include directives not translated to import declarations, and not known to be textual.
>
> Using remarks is suitable and the new name -Rmodule-include-translation looks good to me.
>
> Thanks for mentioning similar options from GCC. The names feel a bit odd to me as I am thinking what "lang-info" means.

GCC does not have the exact equivalent of 'remark' (so lang-info is something specific to the language being compiled).

This seems like something we should aim to get into llvm-15, so LGTM given the comments above.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130138/new/

https://reviews.llvm.org/D130138