[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

[Srishti Srivastava via Phabricator via cfe-commits]

srishti-pm marked an inline comment as done.
srishti-pm added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:238
+    // Stores the mapping between an operand and its BFS traversal information.
+    DenseMap<Value, OperandBFS *> operandToItsBFSMap;
+
----------------
Mogball wrote:
> Why can't you sort the OperandBFS directly to avoid the hash map?
Because comparators are not allowed to modify their input arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124750/new/

https://reviews.llvm.org/D124750