[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

[Fangrui Song via Phabricator via cfe-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146
+    Arg *A;
+    if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None)
+      D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation)
----------------
compnerd wrote:
> This should be hoisted out, this will occur with or without relaxation.  That is, `-mrelax` and `-mno-relax` are both problematic.
No. -mno-relax is supported with -gsplit-dwarf. I think the current code is correct.


================
Comment at: clang/test/Driver/riscv-features.c:41
+// RUN: not %clang -c --target=riscv64 -gsplit-dwarf=single %s 2>&1 | FileCheck %s --check-prefix=ERR-SPLIT-DWARF
+// RUN: %clang -### -c --target=riscv64 -mno-relax -g -gsplit-dwarf %s 2>&1 | FileCheck %s --check-prefix=SPLIT-DWARF
+
----------------
compnerd wrote:
> Can you please add a `-mno-relax` check as well?
The line you reference has `-mno-relax` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130190/new/

https://reviews.llvm.org/D130190