[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 20 13:26:07 PDT 2022
compnerd added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10
#include "RISCV.h"
+#include "../Clang.h"
#include "ToolChains/CommonArgs.h"
----------------
This feels like a layering violation. I suppose that as long as modular builds are okay ...
================
Comment at: clang/test/Driver/riscv-features.c:40
+// RUN: not %clang -c --target=riscv64-linux-gnu -gsplit-dwarf %s 2>&1 | FileCheck %s --check-prefix=ERR-SPLIT-DWARF
+// RUN: not %clang -c --target=riscv64 -gsplit-dwarf=single %s 2>&1 | FileCheck %s --check-prefix=ERR-SPLIT-DWARF
+// RUN: %clang -### -c --target=riscv64 -mno-relax -g -gsplit-dwarf %s 2>&1 | FileCheck %s --check-prefix=SPLIT-DWARF
----------------
Did you mean to add `-###` to these two?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130190/new/
https://reviews.llvm.org/D130190
More information about the cfe-commits
mailing list