[PATCH] D67025: Add .inl as valid C++ header type

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 20 04:13:02 PDT 2022


aaron.ballman added a comment.

> This seems to be a common practice.

FWIW, I did a search over github repos and this file extension is used, but I would hardly call it a common practice (compared to other extensions we don't support, like `.inc`). It does seem to be used as a header-like file, predominately, but I'm not really certain whether there is sufficient evidence that we should treat this extension as always being a header file given that it's not a super common extension (it doesn't help that I've never seen that extension used in the wild before; today was the first time I learned of it). My understanding is that we're usually pretty conservative with this list, and this is why we have the `-x` option so that users can specify a specific language mode to use. Is there a reason that option does not suffice for clangd?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67025/new/

https://reviews.llvm.org/D67025



More information about the cfe-commits mailing list