[PATCH] D129864: [Flang] Generate documentation for compiler flags

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 20 03:57:12 PDT 2022


awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

The change in ClangOptionDocEmitter.cpp is required for Flang as it heavily relies on these "include" flags defined in Options.td <https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td>. This won't affect Clang as it does not use `IncludeFlags` in ClangOptionsDocs.td <https://github.com/llvm/llvm-project/blob/2224bbcd7409c54770d1eaaed527e8dd344acfef/clang/include/clang/Driver/ClangOptionDocs.td#L9-L33>. If Clang devs were to use them in "ClangOptionsDocs.td", the required hooks in ClangOptionDocEmitter.cpp will already be there :)

LGTM, thanks for working on this! Give it another day before merging - in case Clang folks would like to chime in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129864/new/

https://reviews.llvm.org/D129864



More information about the cfe-commits mailing list