[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel Burton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 19 19:22:27 PDT 2022


Ariel-Burton added inline comments.


================
Comment at: clang/lib/Sema/SemaType.cpp:7116
+  for (;;) {
+    if (const TypedefType *TT = dyn_cast<TypedefType>(Desugared)) {
+      Desugared = TT->desugar();
----------------
rnk wrote:
> This seems like a good place to use getSingleStepDesugaredType to look through all type sugar (parens, typedefs, template substitutions, etc).
> This seems like a good place to use getSingleStepDesugaredType to look through all type sugar (parens, typedefs, template substitutions, etc).

I'm not sure what you mean.  Could you expand a little, please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130123/new/

https://reviews.llvm.org/D130123



More information about the cfe-commits mailing list