[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules
Chuanqi Xu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 19 19:01:21 PDT 2022
ChuanqiXu added a comment.
In D129748#3662498 <https://reviews.llvm.org/D129748#3662498>, @erichkeane wrote:
> I'll note that I don't "like" the idea, so much as I see this patch as an 'improvement' to unblock efforts with additional value, though not much of one. I suspect as Aaron does that there is a significant problem that needs fixing here with how our serialization works, and that we should be putting effort into fixing that.
>
> As far as THIS patch, I would be OK with 'holding my nose' and accepting it short-term so we can get Module-ized versions of the STL into clang-15, but only if someone was still actively working ot figure out our serialization problem, and only if Tom/Aaron are OK holding their nose as well.
Oh, got it. Sorry for misunderstanding. The conclusion here makes sense. I would try to look at the serialization problem in a long term.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129748/new/
https://reviews.llvm.org/D129748
More information about the cfe-commits
mailing list