[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

[Abraham Corea Diaz via Phabricator via cfe-commits]

abrahamcd added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:80-81
             Args.getLastArg(options::OPT_dynamic, options::OPT_mdynamic_no_pic))
-      D.Diag(diag::err_drv_argument_not_allowed_with) << A->getAsString(Args)
-                                                      << "-static";
+      D.Diag(diag::err_drv_argument_not_allowed_with)
+          << A->getAsString(Args) << "-static";
 }
----------------
vaibhav.y wrote:
> nit: Looks like this an unrelated format change/ rebase issue. There are a few others as well in this file
> 
> Would be better to introduce these through another CR, or use `git clang-format <commit-start> [<commit-end>]` to limit it to the diff.
Thanks! Did not realize format changed all that :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129886/new/

https://reviews.llvm.org/D129886