[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

[Abraham Corea Diaz via Phabricator via cfe-commits]

abrahamcd added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009-4011
+    if (StringRef(A->getValue()) == "sarif") {
+      D.Diag(diag::warn_drv_sarif_format_unstable);
+    }
----------------
cjdb wrote:
> aaron.ballman wrote:
> > Do we want to be kind to people who spell it SARIF (given that it's an acronym, some folks may spell it that way reflexively)?
> tbh I think it's worth accepting both `sarif` and `SARIF`, if we can.
Ah yeah that would definitely be helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129886/new/

https://reviews.llvm.org/D129886