[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 19 12:05:37 PDT 2022


jhuber6 added a comment.

In D130096#3663062 <https://reviews.llvm.org/D130096#3663062>, @JonChesterfield wrote:

> A safer bet is to use the current control flow that links in specific bitcode files, but create the global directly instead of linking in the file. That'll give us zero semantic change and a clang that ignores those bitcode files if present.

I think I understand what you're saying better now. We should instead have this controlled as a flag via `clang` that the driver will add. This will just tell us to trigger some backend utility to emit the same code. I can look into doing that, will make it easier to just have the clang driver state that we should emit this for HIP / OpenMP unless `nogpulib` is passed for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096



More information about the cfe-commits mailing list