[PATCH] D130081: Add foldings for multi-line comment.

[Utkarsh Saxena via Phabricator via cfe-commits]

usaxena95 added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:351
+        int c;
+        [[// A comment 
+        // expanding more than
----------------
hokein wrote:
> For this case, my personal preference would be to have 3 different foldings, rather than a union one.
> 
> If you think about cases like below, it makes more sense to have individual folding per comment.
> 
> ```
> /* comment 1
> */
> 
> /* comment 2
> */
> ```
> 
> ```
> /* comment 1
> */
> 
> // comment 2
> ```
In the cases mentioned, I think these comments would be about the same context. If I want to fold (possibly long) comments with interleaved new lines, I would be interested in folding all the related comments to look at the code clearly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130081/new/

https://reviews.llvm.org/D130081