[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:9456
+        llvm::ConstantInt::get(Type, Value), Name, nullptr,
+        llvm::GlobalValue::ThreadLocalMode::NotThreadLocal, 4);
+    GV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Local);
----------------
Should use the address space enum


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:9463
+  // TODO: Add flags to toggle these as-needed.
+  bool DenormAtZero = !((Features & llvm::AMDGPU::FEATURE_FAST_FMA_F32) &&
+                        (Features & llvm::AMDGPU::FEATURE_FAST_DENORMAL_F32));
----------------
Typo At


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096