[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 12:46:17 PDT 2022


Meinersbur added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209
+  OMPLexicalScope Scope(*this, S, OMPD_unknown);
+  if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) {
+    llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBuilder();
----------------
Instead of `S.clauses().size() == 0`, could we make it more explicit and extendable by adding a function like `isSupportedbyOpenMPIRBuilder(S)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129992/new/

https://reviews.llvm.org/D129992



More information about the cfe-commits mailing list