[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

[Konrad Wilhelm Kleine via Phabricator via cfe-commits]

kwk added subscribers: tstellar, serge-sans-paille, kwk.
kwk added inline comments.
Herald added a project: All.


================
Comment at: clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp:1
+#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h"
 #include "ClangTidyTest.h"
----------------
@LegalizeAdulthood I'm doing standalone builds of the LLVM projects and we're seeing an error that this file cannot be found. I wonder why this even worked before because we're essentially checking out (or better extract) `clang` into `/clang-15.0.0-src/` and `clang-extra-tools` into `clang-extra-tools-15.0.0-src`. So no matter how smart you design your `-I` include path flags, there`ll never be a `../../clang` that contains the file to be included here. @tstellar does this ring a bell? I've looked at this with @serge-sans-paille today and be both thought this cannot work. Here's the logfile {F23837155} of this build (which might be unreachable in a few days): https://download.copr.fedorainfracloud.org/results/@fedora-llvm-team/llvm-snapshots/fedora-35-x86_64/04639555-clang/builder-live.log.gz


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56303/new/

https://reviews.llvm.org/D56303