[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

as discussed offline i don't see much value in having an extra flag to choose between ast-based and pseudo-based implementation, as the pseudo-based one is a super-set of the ast-based implementation. hence it shouldn't be regressing change in any way, therefore i am in favor of just using the pseudo based implementation inside clangdserver at all times (this is already hidden behind a flag ATM).

independent of that, branch cut is next tuesday. so i'd rather not land it until the cut happens (existing implementation is also crashing, but it's the devil we know and it would be nice to not introduce new failures).



================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:855
+    };
+    WorkScheduler->runQuick("FoldingRangesWithoutAST", File, std::move(Action));
+  }
----------------
i think choice of `runQuick` deserves a comment. something like `We want to make sure folding ranges are always available for all the open files, hence prefer runQuick to not wait for operations on other files`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130011/new/

https://reviews.llvm.org/D130011