[PATCH] D130005: [clang-tidy] Prettify GlobList before serializing Options

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 06:07:10 PDT 2022


njames93 created this revision.
njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, aheejin.
Herald added a project: clang-tools-extra.

When dumping the options, canonicalize the GlobList style options before we serialize them.
This improves formatting as it prevents mixup when newlines and commas are used in different config files as seperators.
It also removes any glob items that appear before a match all as they are disregarded.

Depends on D129706 <https://reviews.llvm.org/D129706>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130005

Files:
  clang-tools-extra/clang-tidy/ClangTidyOptions.cpp
  clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-files/.clang-tidy
  clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-files/1/.clang-tidy
  clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp
  clang-tools-extra/test/clang-tidy/infrastructure/config-files.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130005.445473.patch
Type: text/x-patch
Size: 6637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220718/e024c547/attachment.bin>


More information about the cfe-commits mailing list