[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

Zixuan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 00:42:04 PDT 2022


zixuan-wu added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:660
+
+    if (RVArch == llvm::Triple::riscv64 &&
+        ArchName.startswith_insensitive("rv32"))
----------------
eopXD wrote:
> Do we need to throw error (or warning) when these two (`RVArch` and `ArchName`) don't match?
It just overrides it as before to not report error when for example default triple is rv64 with user passing -march=rv32xxx


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129824/new/

https://reviews.llvm.org/D129824



More information about the cfe-commits mailing list