[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

zhouyizhou via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 16 23:43:28 PDT 2022


zhouyizhou added a comment.

In D129953#3657920 <https://reviews.llvm.org/D129953#3657920>, @njames93 wrote:

> While you're here could you also put full stops( or periods 🙃) at the end of the sentences.

Thank Nathan for reviewing my patch
I am here, and am very happy to make further enhancement ;-) But because my native language is not English, I don't know where should I put the full stops at . 
Isn't  "If the if statement is the last statement of its enclosing statements scope, we can pull the decl out of the if statement." constitute a complete sentence?

Thanks again
Zhouyi


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129953/new/

https://reviews.llvm.org/D129953



More information about the cfe-commits mailing list