[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

[zhouyizhou via Phabricator via cfe-commits]

zhouyizhou created this revision.
zhouyizhou added reviewers: njames93, nridge, alexfh_, stephenkelly.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
zhouyizhou requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Hi,
I think we should add add preposition "of" to code annotation of  ElseAfterReturnCheck ;-)
Many Thanks Zhouyi

Zhouyi Zhou <zhouzhouyi at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129953

Files:
  clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp


Index: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
+++ clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
@@ -263,7 +263,7 @@
     if (!WarnOnConditionVariables)
       return;
     if (IsLastInScope) {
-      // If the if statement is the last statement its enclosing statements
+      // If the if statement is the last statement of its enclosing statements
       // scope, we can pull the decl out of the if statement.
       DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
                                << ControlFlowInterruptor
@@ -299,7 +299,7 @@
     if (!WarnOnConditionVariables)
       return;
     if (IsLastInScope) {
-      // If the if statement is the last statement its enclosing statements
+      // If the if statement is the last statement of its enclosing statements
       // scope, we can pull the decl out of the if statement.
       DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
                                << ControlFlowInterruptor


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129953.445289.patch
Type: text/x-patch
Size: 1155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220717/9ba2d917/attachment.bin>