[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

Fri Jul 15 10:03:05 PDT 2022

ASDenysPetrov added a comment.

@manas

I'm sorry but it seems like I brought you a new work :-) I've just loaded these two patches (D129678 <https://reviews.llvm.org/D129678> and D129498 <https://reviews.llvm.org/D129498>) and now you have to rebase your changes. But there is a good news as well. You will be able to use `clang_analyzer_value` function for your tests if needed.

I appreciate your efforts but I should tell that I'm currently working on the thing that should resolve the issue you are trying to solve D103096 <https://reviews.llvm.org/D103096>.

> The coverage showing unreachability of `VisitBinaryOperator<BO_NE>` for concrete integer cases.

Maybe it's better to remove that unreachable part but leave the tests for concrete ints just to verify that all the cases are covered.

Also I expect to see test case for `short-ushort`, `char-uchar` pairs, because if it would turn out that the `int-uint` is only pair that we handle the patch would be disappointing, unfortunately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112621/new/

https://reviews.llvm.org/D112621