[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

Fri Jul 15 07:30:31 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM!

================
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444
+  if (Better1 && Better2) {
+    bool ClangABICompat14 = S.Context.getLangOpts().getClangABICompat() <=
+                            LangOptions::ClangABI::Ver14;
----------------
ychen wrote:
> aaron.ballman wrote:
> > Can you add CodeGen test coverage for both ABI modes (new RUN line with `-fclang-abi-compat=14`)
> Some test cases could reach the CodeGen phase *with* `-fclang-abi-compat=14`(i.e without this patch), some test cases could reach the CodeGen phase *without* `-fclang-abi-compat=14`(i.e with this patch). Please let me know if the added CodeGen tests are what you expected.
Yes, that test is what I was looking for, thank you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128745/new/

https://reviews.llvm.org/D128745